Post-Implementation refactoring of application

jotoho commented

2021-09-10 17:21:37 +02:00

Owner

Now that the software's initial implementation is completed, I want to try and improve the readability and maintainability of this tool by extracting logic and functionality from start.kt into smaller files and doing some minor internal refactoring. I also hope to do some sort of automated testing (writing tests) but that may be another PR.

jotoho added the

enhancement

label 2021-09-10 17:21:37 +02:00

jotoho self-assigned this 2021-09-10 17:21:37 +02:00

jotoho changed title from ~~Post-Implementation refactoring of application~~ to WIP: Post-Implementation refactoring of application

2021-09-15 21:55:24 +02:00

jotoho force-pushed refactoring from a9cde56333 to 92a226dd02

2021-09-19 19:52:46 +02:00

Compare

jotoho added 1 commit 2021-09-19 20:02:10 +02:00

ad869f7346

Back to Java version 16

Gradle and Kotlin don't yet support Java 17, apparently. :(

This commit reverts 7f725b345c

jotoho added 2 commits 2021-09-19 20:11:12 +02:00

9aba3f156a

Apply IntelliJ code formatting and alternatives suggestions

5919c26c10

Apply formatting suggestion for build config

jotoho added 1 commit 2021-09-19 20:13:20 +02:00

a48f122296

Delete unneeded comment from build config

jotoho added 2 commits 2021-09-19 20:27:37 +02:00

4ab78f4028

Avoid unnecessary temporary variable in short-hand translation

5a80ac7169

Fix compile script using old source path

jotoho changed title from ~~WIP: Post-Implementation refactoring of application~~ to Post-Implementation refactoring of application

2021-09-19 20:35:21 +02:00

jotoho commented

2021-09-19 20:40:43 +02:00

Author

Owner

This MR is quite a leap in technical and maintainablity terms compared to the current state of master.

I have been able to get rid of the annoying app directory, the project now automatically uses the newest versions of it's dependencies, the formatting of the code and build files has been modified to be more in line with Kotlin style guidelines and many more improvements have been made while the behaviour and user-experience remains exactly the same - which is the goal of a refactoring.

Because of this and my testing regarding the MR, I believe that it is now ready for merging and significant enough to warrant a new patch release (0.1.1). I will mark and publish that release version after the merge is complete.

MERGING WITHOUT APPROVALS due to being the only developer.

This MR is quite a leap in technical and maintainablity terms compared to the current state of `master`. I have been able to get rid of the annoying app directory, the project now automatically uses the newest versions of it's dependencies, the formatting of the code and build files has been modified to be more in line with Kotlin style guidelines and many more improvements have been made while the behaviour and user-experience remains exactly the same - which is the goal of a refactoring. Because of this and my testing regarding the MR, I believe that it is now ready for merging and significant enough to warrant a new patch release (`0.1.1`). I will mark and publish that release version after the merge is complete. MERGING WITHOUT APPROVALS due to being the only developer.

jotoho merged commit 4238605180 into master

2021-09-19 20:40:50 +02:00

jotoho deleted branch refactoring

2021-09-19 20:40:50 +02:00

jotoho referenced this issue from a commit

2021-09-19 20:40:50 +02:00

Merge pull request 'Post-Implementation refactoring of application' (#9) from refactoring into master

Post-Implementation refactoring of application #9